build(docker): pin the dhi.io base images by tag only - #33
Merged
Merged
Conversation
dhi.io republishes its tags often to ship vulnerability fixes, and a tag@sha256 pin turned each of those into a Dependabot pull request. Keep the tag and drop the digest, so a rebuild picks up the fixed bases. The Dockerfile frontend stays pinned by digest. Update the release docs, AGENTS.md and the review skill to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dhi.io republishes its tags often to ship vulnerability fixes, and a
tag@sha256pin turned each of those into a Dependabot pull request. This keeps the tag pin (for exampledhi.io/golang:1.26.8-alpine3.23-dev,dhi.io/static:20250419) and drops the digest, so a rebuild picks up the fixed bases.deployments/docker/Dockerfile: the@sha256:…suffix is removed from everydhi.ioFROMline, and the header comment explains the tag-only policy. The# syntax=frontend stays pinned by digest.docs/release.md: the base images are described as pinned by tag, so a rebuild of the same commit uses whatever the tags point to at that time.Verified:
docker build -f deployments/docker/Dockerfile .succeeds and the pre-commit hooks pass on the changed files. Nodhi.io/…@sha256reference is left in the repo.Pull request checklist
masterbranchmake checklocally before creating the commit and it has run successfullyWIPcommits in this PRType of changes