Skip to content

chore(repo): standardize the scaffolding - #29

Merged
leinardi merged 4 commits into
masterfrom
chore/standardize-scaffolding
Sep 28, 2026
Merged

leinardi merged 4 commits into
masterfrom
chore/standardize-scaffolding

Conversation

@leinardi

Copy link
Copy Markdown
Owner

Summary

Aligns this repository with the shared baseline used across the leinardi repositories.

  • ci(repo): reviewdog actions pinned to gha-pre-commit-reviewdog-actions v1.0.2, the pre-commit warm-up to
    gh-reusable-workflows v1.3.0; reviewdog jobs run on pull requests only; enable-beta-ecosystems dropped; issue template
    config.yml.
  • build(make): make-common v1.6.1, plus the "do not add recipes" Makefile footer. The GOOS=linux override on
    go-build still applies.
  • ci(release): the strict resolver from swarm-scheduler-exporter: every tag lookup goes through RELEASE_TAG_REGEX, and svu
    is given the exact tag to count from instead of a glob that also matched pre-release and malformed tags. The stale "stray
    local v1.0.0" note in the release docs is replaced (v1.0.0 is a real release now).
  • docs(agents): CLAUDE.md removed (Claude Code reads AGENTS.md); the per-type version table; skills synced, including
    a rewrite of the outdated "cgroup v2 programs are append-only" invariant (applies swap the owned program; every pass
    re-applies). AGENTS.md now points at go-style-guide §18 for reuse.

Left for a follow-up: internal/config/loader.go:61,96 carry //nolint:gochecknoglobals for a linter that is disabled.

Verification

  • make check (every hook on every file), make go-test and make audit-deps pass locally.
  • The resolve step was extracted from the workflow and run against throwaway repositories: no base tag, malformed and
    leading-zero versions, feat/fix/breaking bumps, "nothing to bump", derived and explicit recovery on HEAD, a lower or equal
    version, and a latest release tagged off the branch.
  • make pre-commit-install installs the commit-msg hook: update stuff and fix: x are rejected, fix(ci): x passes.

No commit here is a feat or a fix, so none of them triggers a release on its own.

Pin the reviewdog actions to gha-pre-commit-reviewdog-actions v1.0.2 and the
pre-commit warm-up to gh-reusable-workflows v1.3.0, drop the
enable-beta-ecosystems flag Dependabot no longer needs for pre-commit, and
align the shared hook configuration with the sibling repositories.
Refresh the bootstrap script and the shared snippets with
make mk-common-update, and add the "do not add recipes" footer from
Makefile.sample.
Only strict vX.Y.Z tags are releases: every lookup filters the tag list
through RELEASE_TAG_REGEX, and svu is given the exact tag to count from
instead of a glob, which also matched pre-release and malformed tags. A
derived version whose tag is already on HEAD is a recovery, not "nothing to
bump", and a latest release tagged off the branch is named in the failure.
Claude Code reads AGENTS.md directly, so CLAUDE.md is not needed. Document
the version each commit type produces, and sync the generic parts of the
go-style-guide and adversarial-review skills with the sibling repositories,
correcting rules that did not match the linters.
@leinardi
leinardi marked this pull request as ready for review September 28, 2026 19:54
@leinardi
leinardi merged commit 8a69535 into master Sep 28, 2026
9 checks passed
@leinardi
leinardi deleted the chore/standardize-scaffolding branch September 28, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant