New: Convert train.dat parser to block format#1361
Open
leezer3 wants to merge 4 commits into
Open
Conversation
Owner
Author
|
Some further thoughts / notes: Errors are currently commented out, need to add the current line property. Licence headers wise, we could probably now add BSD-2 to this file when it's been cleaned up- There's still some duplicate bits and bobs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP...
This PR converts the train.dat parser to block format.
Same basic idea as the other parsers, but in this case is primarily to get this closer to a clean licence state.
Need to investigate further whether we can modify TE2 a bit to use the common plugin when loading train properties; if we can do this it'd probably get rid of plenty of duplicate code.