Skip to content

Add Xquik registry lookup coverage - #1

Open
kriptoburak wants to merge 3 commits into
leefowlercu:masterfrom
kriptoburak:codex/add-xquik-registry-sdk-example-1152
Open

Add Xquik registry lookup coverage#1
kriptoburak wants to merge 3 commits into
leefowlercu:masterfrom
kriptoburak:codex/add-xquik-registry-sdk-example-1152

Conversation

@kriptoburak

@kriptoburak kriptoburak commented Jul 4, 2026

Copy link
Copy Markdown

Summary

  • add an Xquik hosted MCP lookup case for slash-qualified registry names
  • verify exact versions, remote transport metadata, secret headers, and source repository fields
  • document the hosted lookup in the README and get example
  • assert the encoded request path so slash-qualified fixtures cannot silently return the default 404
  • fix RateLimitError.Is so logically identical errors compare URL values safely, including nil URLs

Validation

  • gofmt -w mcp/servers_test.go mcp/errors.go mcp/errors_test.go
  • go test ./...
  • go test -race ./...
  • go vet ./...
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acde2579af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mcp/servers_test.go
@kriptoburak

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50575db901

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mcp/errors.go Outdated
@kriptoburak

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 9d9e4e1911

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kriptoburak

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 9d9e4e1911

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant