fix(ci): narrow JSONDict values with cast() to fix ty type-check errors - #87
Open
lee101 wants to merge 1 commit into
Open
fix(ci): narrow JSONDict values with cast() to fix ty type-check errors#87lee101 wants to merge 1 commit into
lee101 wants to merge 1 commit into
Conversation
…checker The ty type-checker reports invalid-argument-type errors when passing dict[str, object] values directly to float(). Wrap the subscript/get accesses with cast(float, ...) so the checker sees a float argument while preserving identical runtime behaviour (the values are already floats at construction time). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
Codex Infinity Start a task on this PR's branch by commenting:
Tasks and logs: https://codex-infinity.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSONDict(dict[str, object]) value accesses withcast(float, ...)before passing tofloat()in the account guard formatting codeinvalid-argument-typeerrors fromtytype-checker in thetype-checkCI jobfloat(...)during dict construction), so the cast is purely for static analysisChanges
rl_trading_agent_binance/trade_binance_live.py: 4 lines changed across error message formatting in_evaluate_hybrid_account_guard()Test plan
ty checklocally on all CI-targeted files — all checks passed🤖 Generated with Claude Code