fix: omit transient enabled state from saved presets#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Saved presets currently include
enabled, which is transient next-turn state. That means/fusion preset savecan accidentally persist whether fusion happened to be armed at the moment the preset was saved.A preset should describe the fusion configuration: worker count, models, thinking levels, budgets, and planner tool mode. It should not silently turn the next request on or off because of stale UI/session state.
Change
enabledfromsnapshotFusionSettings.enabled,applyFusionPresetSettingsstill honors it through the normal settings resolver.enabledand apply without arming fusion.Verification
pnpm test -- tests/presets.test.tspnpm run typecheckpnpm run format:checkgit diff --check