Skip to content

Coding style and Bootstrap 5 compatibility, resolves #77 - #68

Closed
lucaboesch wants to merge 4 commits into
learnweb:masterfrom
lucaboesch:codingstyle
Closed

Coding style and Bootstrap 5 compatibility, resolves #77#68
lucaboesch wants to merge 4 commits into
learnweb:masterfrom
lucaboesch:codingstyle

Conversation

@lucaboesch

Copy link
Copy Markdown
Contributor

This makes the automated tests pass again for mod_scheduler.
Note there is also #64 included since it assures passing for Bootstrap 4 as well as Bootstrap 5.

@KaiNieLC

Copy link
Copy Markdown

The bootsrap fix #64 doesn't work for me in #68 .

Dropdowns won't open and the code still shows data-toggle instead of data-bs-toggle.

@lucaboesch
lucaboesch force-pushed the codingstyle branch 4 times, most recently from 0bd31a0 to f261e43 Compare July 25, 2026 22:38
@lucaboesch

lucaboesch commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

What is mentioined here #68 (comment) is included in the patch and works, so it also resolves #74 besides #77.
I've rebased and also adapted the amd JavaScript files.

@lucaboesch lucaboesch changed the title Coding style and Bootstrap 5 compatibility Coding style and Bootstrap 5 compatibility, resolves #77 Jul 29, 2026
@lucaboesch

Copy link
Copy Markdown
Contributor Author

This pull request can be closed.

@lucaboesch lucaboesch closed this Aug 4, 2026
@lucaboesch
lucaboesch deleted the codingstyle branch August 4, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants