Add time component to slot's hideuntil setting

[tezvi]

Changed hideuntil setting to include time component. This is a one liner.

Currently we are not able to be more precise when exactly a slot should be visible to students. Especially in situation with multiple slots within a same day. Students will see all slots at once at 00:00 and book them immediately. To prevent that and introduce "fair booking" a time component should be used.

[tezvi]

@bostelm Any chance of merging this?

[bostelm]

Hello
thanks for that patch, and it's certainly easily to merge - that doesn't however mean it's necessarily desirable.
Normally teachers would fill the "hideuntil" field when creating a series of slots, not edit it in individual slots (at least I've never done so). But the "series of slots" form allows only midnight as the start time. Hence I feel I'd be creating an inconsistency here.
I think this feature needs a bit more thought.

[tezvi]

Hi @bostelm!

Thanks for your feedback.

Normally teachers would fill the "hideuntil" field when creating a series of slots, not edit it in individual slots (at least I've never done so).

Well in our Moodle environment that is actually a very common case. One employee opens a series of slots with "general" parameters, another one might choose to limit a certain slot afterwards because of various reasons. Honestly I don't see a problem in having more detailed options in a single slot edit form but of course I could be wrong.

But the "series of slots" form allows only midnight as the start time.

Perhaps we should change it there as well? Are you refering to hideuntilrel form element?

After all, it seems very limited to discard a time component as midnight is not flexible enough and might not work for everyone's needs. Especially when fix is relatively easy and won't disrupt AS-IS usage.

Thanks for your time!