-
-
Notifications
You must be signed in to change notification settings - Fork 302
Websockets #3621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ozer550
wants to merge
70
commits into
unstable
Choose a base branch
from
websockets
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Websockets #3621
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
760298c
intial_websockets_setup
ozer550 798822e
try_fixin_INSTALLED_APPS_error
ozer550 9d2f27c
updated requirements.in file
ozer550 a3bc91b
FIX_Django_Settings_Error
ozer550 44ef339
FIX_test_cases
ozer550 f8d02ed
send_data_from_frontend
ozer550 b0835e3
inject proper channel_id while making websocket request
ozer550 07041bc
implement handel_changes from sync api in websockets
ozer550 b656473
FIX_unit_tests
ozer550 1b9b63c
update redis version
ozer550 b7a39f1
Add more unit tests
ozer550 1508d41
refine pr
ozer550 11ce747
refine PR
ozer550 64dd28f
Merge pull request #3433 from ozer550/websockets_initial_setup
bjester 93c8505
Fix merge conflicts in requirements files
bjester 721a052
setup django signals for change object
ozer550 ad1461a
properly handle cases in signals
ozer550 279daf4
complete tests for signals
ozer550 40a08fe
fix rebase
ozer550 aa54a24
broken test_cannot_create_files
ozer550 4092a3f
fix typecasting
ozer550 cc9982a
add helper functions for tests
ozer550 e9bc522
refactored tests
ozer550 afe273a
fix typos
ozer550 cc1db42
final refactor
ozer550 d9c9b68
moved NoneCreatedByIdError
ozer550 53e77c3
Merge pull request #3471 from ozer550/FEAT_CHANGE_LOG_BROADCASTING
bjester 08e9322
Resolve merge conflicts
bjester 91b927c
Resolve unstable merge conflicts
bjester 035455e
Update websocket consumer to use new task implementation
bjester 97c5661
Merge pull request #3460 from bjester/websockets
bjester fd04a2f
Resolve merge conflicts; unstable -> websockets
bjester c571454
Remove imports not caught in merge conflict resolution
bjester 7668279
Merge pull request #3550 from bjester/unstable-to-websockets-2
bjester bed4154
remould frontend to remove fake task object
ozer550 80f0a87
Refactor create_change_tracker
ozer550 15a4014
fix progress after succes
ozer550 99310c6
Merge pull request #3568 from ozer550/FEAT_TASKS_BROADCASTING
bjester 49da0b7
add recipe for daphne server and change nginx file
ozer550 959ed30
Resolve merge conflicts in requirements.txt
bjester 86c622b
Merge pull request #3595 from ozer550/FEAT_NGINX_CHANGES
bjester 72e41cd
Resolve makefile conflicts
bjester 8a04104
Merge pull request #3599 from bjester/websockets-unstable-merge
bjester c439372
change serverSync.js
ozer550 29e4a66
restructure websocket code
ozer550 15eaf37
added error handeling for socket functions
ozer550 aed085d
coHack
ozer550 9ce6707
Strict created_by_id to not be none
ozer550 262360b
refactored serverSync.js
ozer550 55e3be8
remove unnecessary comments
ozer550 f9874ec
refactor serverSync.js
ozer550 d83df35
change debounce time
ozer550 d970e2d
small tweaks
ozer550 dd4c541
change created_by_id in MaxRev to user.id
ozer550 370abdb
Merge pull request #3607 from ozer550/FEAT_SERVER_SYNC_JS_CLEANUP
bjester 02e3e5f
Handle merge conflicts
bjester dc8178e
Merge pull request #3619 from bjester/websockets
bjester 5cbd4ce
Fix bad merging of Makefile changes
bjester 4673ffe
Merge pull request #3622 from bjester/websockets
bjester 64e4fd7
Remove all make dependencies since they weren't being run anyway
bjester 5670713
Reduce procs to better match current production (2), to avoid overloa…
bjester c06c14d
Merge pull request #3624 from bjester/websockets
bjester 1a4be5f
Fix redis connection trying localhost in production
bjester 20ea181
Merge pull request #3629 from bjester/websockets
bjester 2188634
Added Health Check route for daphne
ozer550 0db9935
removed repetition of code
ozer550 1937be3
Merge pull request #3729 from ozer550/FEAT_HEALTH_CHECK_DAPHNE
bjester df66e8e
Merge branch 'websockets' into websockets-mergedd
bjester a5f35cf
Merge pull request #3735 from learningequality/websockets-mergedd
bjester 99edf3f
Merge pull request #3815 from learningequality/unstable
bjester File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import django | ||
| from channels.auth import AuthMiddlewareStack | ||
| from channels.routing import ProtocolTypeRouter | ||
| from channels.routing import URLRouter | ||
| from django.conf import settings | ||
|
|
||
| from contentcuration.viewsets.websockets.routing import http_urlpatterns | ||
| from contentcuration.viewsets.websockets.routing import websocket_urlpatterns | ||
|
|
||
| django.setup(set_prefix=False) | ||
|
|
||
| protocol_config = { | ||
| "websocket": | ||
| AuthMiddlewareStack( | ||
| URLRouter( | ||
| websocket_urlpatterns | ||
| ) | ||
| ), | ||
| } | ||
|
|
||
| # production settings to add healthcheck | ||
| if not settings.DEBUG: | ||
| protocol_config.update(http=URLRouter(http_urlpatterns)) | ||
|
|
||
| application = ProtocolTypeRouter(protocol_config) |
2 changes: 1 addition & 1 deletion
2
contentcuration/contentcuration/frontend/shared/data/applyRemoteChanges.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this logic is preserving a single task of the type - rather than a single task per type per channel? This might cause weird behaviour if you're editing two channels at once.