Bump cryptography from 46.0.5 to 48.0.1#679
Conversation
Bumps [cryptography](https://github.com/pyca/cryptography) from 46.0.5 to 48.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@46.0.5...48.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-version: 48.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
rtibblesbot
left a comment
There was a problem hiding this comment.
The lock file change is safe — no production code uses cryptography directly, tests/pipeline/test_transfer.py wraps its cryptography imports in try/except ImportError so the test suite degrades gracefully without it, and Windows CI (5/5 Python versions) passes cleanly.
CI note: macOS and Ubuntu test matrix still pending at review time.
One suggestion inline about the unexpected resolution; see comment on uv.lock.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Ran a core review pass only:
- Classified the diff and reviewed the whole PR for correctness, design, testing, and completeness
- Specialized frontend/backend lenses and manual QA run when a review is explicitly requested by a maintainer
- Checked CI status and chose the verdict from the findings, CI status, and available evidence
| ] | ||
|
|
||
| [[package]] | ||
| name = "rsa" |
There was a problem hiding this comment.
suggestion: The PR title says "Bump cryptography from 46.0.5 to 48.0.1" but cryptography doesn't appear in the updated lock at any version — the resolver instead downgraded google-auth from 2.49.1 → 2.47.0, which uses rsa for RSA operations rather than cryptography, effectively removing cryptography from the environment entirely.
This is functionally safe for this project (no production code imports cryptography), but worth a maintainer sanity-check: if the goal was to get cryptography 48.0.1 into the environment, this PR doesn't achieve it. To force it, add cryptography>=48.0.1 as an explicit constraint. If removing cryptography in favour of rsa is acceptable, the PR is fine as-is.
Warning
Dependabot will stop supporting
python v3.9!Please upgrade to one of the following versions:
v3.9,v3.10,v3.11,v3.12,v3.13, orv3.14.Bumps cryptography from 46.0.5 to 48.0.1.
Changelog
Sourced from cryptography's changelog.
... (truncated)
Commits
de987ce48.0.1 version bump and changelog (#14996)8e03e30bump for 48.0.0 release (#14796)295e0d2Add AGENTS.md with CLAUDE.md symlink (#14794)104a2deBump BoringSSL, OpenSSL, AWS-LC in CI (#14793)67ec1e5call check_length early on AesSiv::encrypt (#14792)b2da57achangelog for mldsa/mlkem for openssl (#14791)3cf44adML-KEM OpenSSL support (#14781)2e31639ML-DSA OpenSSL support (#14773)5affe5afix rust nightly clippy (#14790)2e73ca4bump rust-openssl dep and update EcPoint::mul_generator to mul_generator2 (#1...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.