Deps: upgrade for 7.x#32
Open
jankapunkt wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades dependencies and tooling in preparation for the upcoming 7.x release, including switching the test-proxy project’s linting/formatting to Biome and updating the Meteor test environment and CI configuration to newer versions.
Changes:
- Migrate linting from ESLint/StandardJS to Biome (new
test-proxy/biome.json, updated scripts and CI lint job). - Update Meteor test-proxy to Meteor 3.4.1 and refresh related dependencies and package versions.
- Modernize/format server and test code (import ordering, arrow functions, optional chaining) and move tests to core Meteor packages (
meteor/http,Mongo.getCollection).
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/webapp-tests.js | Updates HTTP import to meteor/http and reformats route tests. |
| tests/validation-tests.js | Test formatting updates and minor refactors around validation tests. |
| tests/test-helpers.tests.js | Switches collection lookup helper to Mongo.getCollection. |
| tests/oauth-tests.js | Updates imports (core Meteor HTTP), formatting, and collection lookup usage. |
| tests/model-tests.js | Updates collection access to Mongo.getCollection and reformats async tests. |
| tests/error-tests.js | Formatting-only updates (method definitions, import order). |
| test-proxy/package.json | Replaces StandardJS linting with Biome; updates test-proxy deps/devDeps. |
| test-proxy/biome.json | Adds Biome configuration for linting/formatting. |
| test-proxy/.meteor/versions | Updates Meteor package versions for the test-proxy app. |
| test-proxy/.meteor/release | Bumps Meteor release to 3.4.1. |
| test-proxy/.meteor/packages | Updates pinned Meteor package versions (e.g., mongo/static-html). |
| package.js | Updates Meteor compatibility, npm deps, and test package dependencies. |
| lib/webapp.js | Minor import reordering while keeping body-parser integration. |
| lib/validation/validateParams.js | Formatting updates and catch clause simplification. |
| lib/validation/UserValidation.js | Formatting updates and small refactor to arrow functions. |
| lib/validation/OptionsSchema.js | Removes stray blank line in schema definition. |
| lib/validation/nonEmptyString.js | Formatting update (arrow function param parentheses). |
| lib/utils/isModelInterface.js | Formatting update (arrow function + multi-line return). |
| lib/utils/error.js | Converts handler to arrow function (formatting/consistency). |
| lib/utils/console.js | Formatting changes and export ordering. |
| lib/utils/bind.js | Formatting update (arrow function param parentheses). |
| lib/oauth.js | Reorders/modernizes imports and refactors handlers for clarity. |
| lib/model/model.js | Reformats model methods and updates debug logging calls. |
| lib/model/meteor-model.js | Reformats model implementation functions and Mongo calls. |
| lib/middleware/secureHandler.js | Formatting update and optional chaining for state lookup. |
| lib/middleware/getDebugMiddleware.js | Uses concise arrow middleware and ignores unused params. |
| lib/defaults.js | Simplifies empty responseTypes object formatting. |
| .github/workflows/tests.yml | Updates action versions, Node version, Meteor version, and install commands. |
Comments suppressed due to low confidence (1)
.github/workflows/tests.yml:72
- This cache path points at
.meteor/local/...in the repo root, but the Meteor app is executed intest-proxy/, so these directories won’t exist and the build cache won’t be saved/restored. Point the paths attest-proxy/.meteor/local/...instead.
.meteor/local/resolver-result-cache.json
.meteor/local/plugin-cache
.meteor/local/isopacks
.meteor/local/bundler-cache/scanner
key: v3-meteor_build_cache-${{ github.ref }}-${{ github.sha }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| finish( | ||
| res, | ||
| done, | ||
| new Error('expected GET route to not be callable via POST request') |
|
|
||
| it('returns true if the params math', function () { | ||
| [ | ||
| it('returns true if the params math', () => { |
| }) | ||
| it('throws if fct ist not a function', function () { | ||
| expect(() => UserValidation.register({ instanceId })).to.throw('Match error: Expected function, got undefined') | ||
| it('throws if fct ist not a function', () => { |
Comment on lines
+159
to
+161
| this.log( | ||
| `saveAuthorizationCode (code: ${code} client: ${client} user: ${user})` | ||
| ) |
| uses: actions/cache@v5 | ||
| with: | ||
| path: ~/.meteor | ||
| key: v3-meteor-${{ hashFiles('.meteor/versions') }} |
| uses: actions/cache@v5 | ||
| with: | ||
| path: | | ||
| .meteor/local/resolver-result-cache.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this updates the dependencies for the upcoming 7.x release