Skip to content

Replace invalid sinon.define with Object.defineProperty and cleanup #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jankapunkt merged 3 commits into from
Jan 6, 2026
Merged

Replace invalid sinon.define with Object.defineProperty and cleanup #374

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62f068d
Initial plan
Copilot Dec 17, 2025
44acb89
fix(tests): use Object.defineProperty instead of sinon.define with cl…
Copilot Dec 17, 2025
871ee6c
fix(tests): add writable property to Object.defineProperty
Copilot Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions tests/unit.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,18 +126,30 @@ describe('unit tests', function () {
expect(defaultVoice).to.equal(voices[1])
})
it('sets a language-specific voice as default voice, if no .default is available', async () => {
let navigatorDefined = false
if (globalThis.navigator) {
sinon.stub(globalThis.navigator, 'language').get(() => 'de-DE')
} else {
sinon.define(globalThis, 'navigator', { language: 'de-DE' })
Object.defineProperty(globalThis, 'navigator', {
value: { language: 'de-DE' },
configurable: true,
writable: true
})
navigatorDefined = true
}

const voices = [{}, {}, { lang: 'de_DE' }]
await initScope({
speechSynthesis: { getVoices: () => voices }
})
const { defaultVoice } = EasySpeech.status()
expect(defaultVoice).to.equal(voices[2])
try {
const voices = [{}, {}, { lang: 'de_DE' }]
await initScope({
speechSynthesis: { getVoices: () => voices }
})
const { defaultVoice } = EasySpeech.status()
expect(defaultVoice).to.equal(voices[2])
} finally {
if (navigatorDefined) {
delete globalThis.navigator
}
}
})
it('sets he first available voice as default, if no lang is available', async () => {
const voices = [{}, {}, {}]
Expand Down
Loading