fix: make header mapping type abbreviation - #546
Merged
Conversation
Make the type `HeaderMapping` an abbreviation instead of a definition. This change was intended as part of leanprover#539 and will make leanprover/reference-manual#599 easier to land. There's still [one place remaining](https://github.com/leanprover/reference-manual/blob/main/Manual/Meta/ErrorExplanation.lean#L639-L640) in `Manual/Meta/ErrorExplanation.lean` where it's relying on the implementation of this type, which breaks if typeclass resolution doesn't see the `ForIn` instance on `List`. Of course, we could also expose `ForIn` on `HeaderMapping`, or expose a "close all sections for this `HeaderMapping` but I'd rather decouple that decision from [the present PR](leanprover/reference-manual#599).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the type
HeaderMappingan abbreviation instead of a definition.This change was intended as part of #539 and will make leanprover/reference-manual#599 easier to land. There's still one place remaining in
Manual/Meta/ErrorExplanation.leanwhich relies on the underlying implementation ofHeaderMapping. It's convenient for now to make it anabbrev. Of course, we could also trivially implementForInforHeaderMapping, or expose a "close all sections for thisHeaderMappingbut I'd rather decouple that decision from the present PR.