fix: restore parser tests - #543
Closed
jcreedcmu wants to merge 3 commits into
Closed
Conversation
jcreedcmu
force-pushed
the
restore-tests
branch
from
September 30, 2025 20:27
4deed07 to
ef05e25
Compare
Did:
find . -type f -exec sed -i 's/\bVerso\.Syntax/Lean.Doc.Syntax/g' {} +
find . -type f -exec sed -i 's/expected identifier/expected token/g' {} +
Manually inspected, all are mere whitespace changes or 'identifier' ~ 'token' rewording changes.
jcreedcmu
force-pushed
the
restore-tests
branch
from
September 30, 2025 20:34
ef05e25 to
38881ad
Compare
Collaborator
Author
|
The several commits in this PR were deliberately constructed so that I could |
Collaborator
|
When the parser was upstreamed, the tests went with it: https://github.com/leanprover/lean4/tree/master/tests/lean/docparse I don't think there's a reason to have them two places, and the tests should follow the code. I'll go ahead and close this, please feel free to re-open if there's a detail I missed. |
Collaborator
Author
|
Nope, that's the answer, didn't know why I didn't think of that
…On Wed, Oct 1, 2025, 00:19 David Thrane Christiansen < ***@***.***> wrote:
*david-christiansen* left a comment (leanprover/verso#543)
<#543 (comment)>
When the parser was upstreamed, the tests went with it:
https://github.com/leanprover/lean4/tree/master/tests/lean/docparse
I don't think there's a reason to have them two places, and the tests
should follow the code. I'll go ahead and close this, please feel free to
re-open if there's a detail I missed.
—
Reply to this email directly, view it on GitHub
<#543 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALONFXR2XBI6KRLLKOPJE33VNI5XAVCNFSM6AAAAACH56MXG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNJUGY4DMNJWHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is made to find out the reason why the tests were deleted, or, in the event there wasn't a reason, to put them back.