fix: simp? output order - #9117
Closed
Rob23oba wants to merge 3 commits into
Closed
Conversation
Rob23oba
marked this pull request as ready for review
July 1, 2025 11:25
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Collaborator
|
This hasn't been touched in over a year, and has a merge conflict. I'm closing now; please re-open if you think appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the output order of
simp?and similar tactics to roundtrip more consistently.Breaking change: many functions related to generating
simp onlycalls (e.g.mkSimpCallStx) now require aSimp.Contextand aSimp.SimprocsArrayin order to reorder the lemmas correctlyCloses #4615