chore: permit Lake failures in PR release CI - #6403
Closed
tydeu wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
the
toolchain-available
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 16, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 16, 2024
ghost
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
tydeu
marked this pull request as ready for review
December 16, 2024 21:52
Collaborator
|
I'm not sure what the purpose of this is: it's fine to merge Lean PRs that are labelled |
Collaborator
|
This hasn't been touched in over a year, and has a merge conflict. I'm closing now; please re-open if you think appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the PR release CI to succeed even if Lake fails to update Mathlib's version of Batteries.
This can occur if Lake fails to configure the package due to configuration file errors, such as those that may be caused by changes in the PR. This happened, for instance, in #6388.