feat: set_option for conv mode - #2887
Closed
lecopivo wants to merge 2 commits into
Closed
Conversation
Collaborator
|
You need register_parser_alias optionValuearound here and then (after a stage0 update) syntax (name := «set_option») "set_option " ident ppSpace optionValue " in " convSeq : convin You can probably also implement the conv as a |
|
Collaborator
|
This hasn't been touched in over a year, and has a merge conflict. I'm closing now; please re-open if you think appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting options with
set_option ... in ...was only possible in tactic mode. This PR enables it to do it in conv mode too.The only issue with my fix is that the syntax definition is in
src/Lean/Elab/Tactic/Conv/Basic.leanwhich is clearly a bad place for it. Ideally it should be insrc/Lean/Parser/Command.leanjust next to the definition ofset_optiontactic but I do not know how to write the parser withconvSeq