Skip to content

Use Bool.asProp for coercions - #2060

Closed
gebner wants to merge 4 commits into
masterfrom
boolasprop
Closed

Use Bool.asProp for coercions#2060
gebner wants to merge 4 commits into
masterfrom
boolasprop

Conversation

@gebner

@gebner gebner commented Jan 24, 2023

Copy link
Copy Markdown
Member

Fixes #2043.

Without this change, we would not inline anything inside
let x_42 := casesOn x_3 fun .. => ... here ...
return visit_cases_default(e);
} else {
return e;
return visit_cases_default(e);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change, we would not inline anything inside

let x_42 := Foo.casesOn x_3
  fun .. => ... here ...

@gebner

gebner commented Jan 24, 2023

Copy link
Copy Markdown
Member Author

@gebner

gebner commented Jan 24, 2023

Copy link
Copy Markdown
Member Author

!bench

@leanprover-bot

Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 8b21496.
There were significant changes against commit 345aa6f:

  Benchmark          Metric         Change
  ====================================================
+ qsort              task-clock      -1.4%   (-17.5 σ)
+ qsort              wall-clock      -1.4%   (-17.6 σ)
+ stdlib             instructions    -2.1% (-2365.0 σ)
- stdlib             maxrss           1.1%    (19.7 σ)
+ stdlib             task-clock      -2.5%   (-38.5 σ)
+ stdlib             wall-clock      -2.9%  (-392.4 σ)
- stdlib size        bytes .olean     1.7%
- workspaceSymbols   maxrss           1.1%    (15.4 σ)
+ workspaceSymbols   task-clock      -2.1%   (-10.0 σ)
+ workspaceSymbols   wall-clock      -2.1%   (-10.1 σ)

@fgdorais

fgdorais commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

I really like this but please post something on Zulip when merging since this looks like some significant update changes. A few quick hints might help too. Please remember that mathlib is not the only thing downstream 😄

@Kha
Kha requested review from Kha and leodemoura as code owners November 20, 2023 08:15
@kim-em
kim-em self-requested a review as a code owner May 29, 2024 16:23
@leanprover-bot leanprover-bot added the P-low We are not planning to work on this issue label Mar 19, 2025
@kim-em
kim-em requested a review from zwarich as a code owner June 4, 2025 09:31
@kim-em

kim-em commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

This hasn't been touched in over a year, and has a merge conflict. I'm closing now; please re-open if you think appropriate.

@kim-em kim-em closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P-low We are not planning to work on this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] Implement Boolean-to-Prop coercion using Bool.asProp

5 participants