Use Bool.asProp for coercions - #2060
Closed
gebner wants to merge 4 commits into
Closed
Conversation
Without this change, we would not inline anything inside let x_42 := casesOn x_3 fun .. => ... here ...
gebner
commented
Jan 24, 2023
| return visit_cases_default(e); | ||
| } else { | ||
| return e; | ||
| return visit_cases_default(e); |
Member
Author
There was a problem hiding this comment.
Without this change, we would not inline anything inside
let x_42 := Foo.casesOn x_3
fun .. => ... here ...
Member
Author
|
Required mathlib changes are manageable, as expected: https://github.com/leanprover/std4/compare/pr2060?expand=1 https://github.com/leanprover-community/mathlib4/compare/pr2060?expand=1 |
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 8b21496. Benchmark Metric Change
====================================================
+ qsort task-clock -1.4% (-17.5 σ)
+ qsort wall-clock -1.4% (-17.6 σ)
+ stdlib instructions -2.1% (-2365.0 σ)
- stdlib maxrss 1.1% (19.7 σ)
+ stdlib task-clock -2.5% (-38.5 σ)
+ stdlib wall-clock -2.9% (-392.4 σ)
- stdlib size bytes .olean 1.7%
- workspaceSymbols maxrss 1.1% (15.4 σ)
+ workspaceSymbols task-clock -2.1% (-10.0 σ)
+ workspaceSymbols wall-clock -2.1% (-10.1 σ) |
Contributor
|
I really like this but please post something on Zulip when merging since this looks like some significant update changes. A few quick hints might help too. Please remember that mathlib is not the only thing downstream 😄 |
Collaborator
|
This hasn't been touched in over a year, and has a merge conflict. I'm closing now; please re-open if you think appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2043.