fix: close idle HTTP server connections after the keep-alive timeout - #15043
Open
counter2015 wants to merge 1 commit into
Open
fix: close idle HTTP server connections after the keep-alive timeout#15043counter2015 wants to merge 1 commit into
counter2015 wants to merge 1 commit into
Conversation
This PR fixes HTTP server stalls caused by idle connections retaining connection slots past the configured keep-alive timeout. Schedule the idle timeout before the first request and between requests, closing the connection silently when it expires. Keep the existing timeout behavior once a request starts. Add regression tests for both idle states and for handlers that run longer than the idle timeout. AI assistance: Codex assisted with the implementation, regression tests, and this description. Closes leanprover#15041
Author
|
Validation on macOS ARM64:
The local run covers the HTTP test group; the full Lean test suite and other platforms have not been run locally. |
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
counter2015
marked this pull request as ready for review
September 5, 2026 16:09
Author
|
changelog-library |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
Std.Http.Serverstalls caused by idle connections retaining connection slots past the configured keep-alive timeout.Schedule the idle timeout before the first request and between requests, closing the connection silently when it expires. Keep the existing timeout behavior once a request starts. Add regression tests for both idle states and for handlers that run longer than the idle timeout.
AI assistance: Codex assisted with the implementation, regression tests, and this description.
Closes #15041