Skip to content

fix: lake: apply moreServerOptions to package modules #15042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tydeu merged 1 commit into from
Sep 5, 2026
+14 −1
Merged

fix: lake: apply moreServerOptions to package modules #15042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lake/Lake/Build/Module.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,7 @@ def setupEditedModule
importArts := transImpArts
dynlibs := dynlibs.map (·.path)
plugins := plugins.map (·.path)
options := mod.leanOptions
options := mod.serverOptions
}

/--
Expand Down
7 changes: 7 additions & 0 deletions tests/lake/tests/setupFile/moreServerOptions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
name = "test"

[moreServerOptions]
weak.foo = "baz"

[[lean_lib]]
name = "Test"
6 changes: 6 additions & 0 deletions tests/lake/tests/setupFile/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ test_out '"options":{}' setup-file ImportFoo.lean
# Lake can identify the module corresponding to the path.
test_out '"options":{"weak.foo":"bar"}' setup-file Test.lean

# Test that `moreServerOptions` applies to external modules.
test_out '"options":{"weak.foo":"baz"}' -f moreServerOptions.toml setup-file ImportTest.lean

# Test that `moreServerOptions` applies to internal modules.
test_out '"options":{"weak.foo":"baz"}' -f moreServerOptions.toml setup-file Test.lean

# Test that `setup-file` on an invalid Lean configuration file succeeds.
test_run -f invalid.lean setup-file invalid.lean

Expand Down
Loading