fix: use CMAKE_COMMAND instead of bare cmake in build - #15001
Open
joehendrix wants to merge 1 commit into
Open
Conversation
The add_custom_target copy steps invoked "cmake" directly which uses the version
of cmake on the path at build time. This uses ${CMAKE_COMMAND} -- the
absolute path to the cmake driving the build -- so these steps do not depend
on PATH and always use the same cmake. This matches CMake guidance and the
file's own existing use of ${CMAKE_COMMAND} elsewhere.
joehendrix
changed the title
joehendrix
changed the title
joehendrix
changed the title
github-actions
Bot
added
toolchain-available
Collaborator
|
Reference manual CI status:
|
leanprover-bot
added
the
builds-manual
joehendrix
marked this pull request as ready for review
September 2, 2026 18:39
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces bare uses of cmake in build script with ${CMAKE_COMMAND} to avoid path issues.
This matches CMake guidance and the file's own existing use of ${CMAKE_COMMAND} elsewhere.
The changes in this commit used AI.