Skip to content

perf: do not include scalar children in mark_mt/mark_persistent - #14980

Draft
TwoFX wants to merge 1 commit into
leanprover:masterfrom
TwoFX:julia/mt
Draft

perf: do not include scalar children in mark_mt/mark_persistent#14980
TwoFX wants to merge 1 commit into
leanprover:masterfrom
TwoFX:julia/mt

Conversation

@TwoFX

@TwoFX TwoFX commented Aug 31, 2026

Copy link
Copy Markdown
Member

No description provided.

@TwoFX

TwoFX commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

!radar

@leanprover-radar

leanprover-radar commented Aug 31, 2026

Copy link
Copy Markdown

Benchmark results for 259f5b0 against ac0f56e are in. No significant results found. @TwoFX

  • build//instructions: -9.7G (-0.09%)

Medium changes (1✅)

  • compiled/iterators//instructions: -3.4M (-0.63%)

Small changes (3✅, 1🟥)

  • compiled/select//instructions: -12.6M (-0.46%)
  • elab/bv_decide_inequality//wall-clock: -58ms (-1.47%)
  • 🟥 elab/whnfMatcherImplicitTransparencyCaching//maxrss: +26MiB (+5.27%)
  • lake/inundation/startup//instructions: -3.1M (-1.54%)

@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 31, 2026
@leanprover-bot

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-08-30 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-08-31 10:47:01)

@github-actions github-actions Bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Aug 31, 2026
@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 31, 2026
@mathlib-lean-pr-testing

Copy link
Copy Markdown

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants