Skip to content

perf: avoid copying mpz wrappers - #14978

Closed
TwoFX wants to merge 1 commit into
leanprover:masterfrom
TwoFX:julia/mpz-move
Closed

perf: avoid copying mpz wrappers#14978
TwoFX wants to merge 1 commit into
leanprover:masterfrom
TwoFX:julia/mpz-move

Conversation

@TwoFX

@TwoFX TwoFX commented Aug 31, 2026

Copy link
Copy Markdown
Member

AI-generated

@TwoFX

TwoFX commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

!radar

@leanprover-radar

leanprover-radar commented Aug 31, 2026

Copy link
Copy Markdown

Benchmark results for 7120e68 against ac0f56e are in. There are significant results. @TwoFX

  • 🟥 build//instructions: +910.2M (+0.01%)

Large changes (1✅)

  • compiled/liasolver//instructions: -569.1M (-16.96%)

Medium changes (2✅)

  • compiled/liasolver//task-clock: -22ms (-13.05%)
  • compiled/liasolver//wall-clock: -22ms (-13.09%)

@TwoFX

TwoFX commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

!bench mathlib

@leanprover-radar

leanprover-radar commented Aug 31, 2026

Copy link
Copy Markdown

Benchmark results for leanprover-community/mathlib4-nightly-testing@8128950 against leanprover-community/mathlib4-nightly-testing@2415714 are in. No significant results found. @TwoFX

  • 🟥 build//instructions: +83.9G (+0.06%)

No significant changes detected.

@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 31, 2026
@leanprover-bot

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-08-30 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-08-31 09:15:55)

@github-actions github-actions Bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Aug 31, 2026
@TwoFX TwoFX closed this Aug 31, 2026
@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 31, 2026
@mathlib-lean-pr-testing

Copy link
Copy Markdown

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants