You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR allows rfl to prove equality between distinct opaque constants whose common type is unit-like, fixing #14348.
The definitional equality checker now falls back to its existing unit-like check only when two constant names differ, preserving the fast path for identical constants. A regression test covers two opaque Unit constants.
AI assistance was used to locate the diagnosed control-flow branch and draft the minimal patch and regression test. I manually reviewed the change and verified the clean build and focused test.
The syntax error is fixed in commit 0ebf6be; distinct constants now fall through to the existing unit-like check while identical constants keep the universe-level fast path. The PR body check also requires a changelog label, but fork contributors cannot add upstream labels. Maintainers: please add changelog-language (or the category you prefer).
The focused 14348 regression passed in the refreshed CI. The remaining failure was trace-only: distinct non-unit constants were falling through the general expensive path and adding isDefEq.onFailure trace entries. Commit 2fdb446267 now sends distinct constants directly to isDefEqUnitLike; non-unit-like types return false immediately, preserving the previous trace/control-flow boundary.
❗ Mathlib CI can not be attempted yet, as the nightly-testing-2026-07-25 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2026-07-30 20:43:39)
❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 58774429865502f05c63239266aac30ef1e91ef7 --onto c632a0a0e434a951cdcf61bb4da3344abadd5587. You can force Mathlib CI using the force-mathlib-ci label. (2026-09-04 00:36:05)
🟡 Reference manual branch lean-pr-testing-14550 build against this PR didn't complete normally. (2026-07-30 20:50:39) View Log
✅ Reference manual branch lean-pr-testing-14550 has successfully built against this PR. (2026-07-30 20:51:05) View Log
✅ Reference manual branch lean-pr-testing-14550 has successfully built against this PR. (2026-07-30 21:16:55) View Log
🟡 Reference manual branch lean-pr-testing-14550 build against this PR didn't complete normally. (2026-07-30 21:17:13) View Log
❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 58774429865502f05c63239266aac30ef1e91ef7 --onto 19c79593c47bb8dd3371327c08fc80775d8488af. You can force reference manual CI using the force-manual-ci label. (2026-09-04 00:36:06)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builds-manualCI has verified that the Lean Language Reference builds against this PRchangelog-languageLanguage features and metaprogramstoolchain-availableA toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows
rflto prove equality between distinct opaque constants whose common type is unit-like, fixing #14348.The definitional equality checker now falls back to its existing unit-like check only when two constant names differ, preserving the fast path for identical constants. A regression test covers two opaque
Unitconstants.Tests
tests/with_stage1_test_env.sh tests/elab/run_test.sh 14348.leanChangelog
changelog-languageAI assistance
AI assistance was used to locate the diagnosed control-flow branch and draft the minimal patch and regression test. I manually reviewed the change and verified the clean build and focused test.