Skip to content

fix: drop widget rendering from public proof states - #3

Merged
ejgallego merged 3 commits into
mainfrom
codex/ci-goal-render-fix
Mar 16, 2026
Merged

fix: drop widget rendering from public proof states#3
ejgallego merged 3 commits into
mainfrom
codex/ci-goal-render-fix

Conversation

@ejgallego

@ejgallego ejgallego commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove Lean.Widget.goalToInteractive from the public proof-state path
  • render Goal / GoalHyp directly as plain strings from proof snapshots
  • keep the public JSON shape while removing widget-tag complexity we do not expose

Why

  • the public runAt proof-state payload only exposes plain strings
  • the old widget rendering path added complexity and surfaced transport internalError under repeated proof-handle workload pressure
  • direct plain-string rendering is both simpler and more robust for the current API

Testing

  • lake build RunAt:shared runAt-search-workload-report runAt-test
  • ./.lake/build/bin/runAt-test tests/interactive/proofConstructorBoundary.lean
  • loaded runAt-search-workload-report 48 20260321 batch: 5/5 success under 24-core synthetic load

Notes

  • this intentionally keeps the current public JSON shape
  • widget-based rendering is no longer used for public proof-state construction

@ejgallego ejgallego changed the title fix: make proof state rendering resilient to widget pp failures fix: drop widget rendering from public proof states Mar 16, 2026
@ejgallego
ejgallego merged commit ab00c61 into main Mar 16, 2026
8 checks passed
@ejgallego
ejgallego deleted the codex/ci-goal-render-fix branch March 16, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant