Skip to content

[Merged by Bors] - chore: golf mvfderiv(Within)_zero - #43986

Closed
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:golf-mfderiv-zero
Closed

grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:golf-mfderiv-zero

Conversation

@grunweg

@grunweg grunweg commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

We can reuse a previous lemma, and remove a superfluous hypothesis at the same time.


Open in Gitpod

We can reuse a previous lemma, and remove a superfluous hypothesis at the same time.
@grunweg grunweg added the easy < 20s of review time. See the lifecycle page for guidelines. label Sep 20, 2026
@grunweg grunweg mentioned this pull request Sep 20, 2026
1 task
@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

PR summary 23e3311fe6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit 23e3311).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 23e3311fe6
Reference commit b1007d8abf

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 22, 2026

@j-loreaux j-loreaux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Sep 22, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 22, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Sep 22, 2026
We can reuse a previous lemma, and remove a superfluous hypothesis at the same time.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Sep 22, 2026
@mathlib-bors

mathlib-bors Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore: golf mvfderiv(Within)_zero [Merged by Bors] - chore: golf mvfderiv(Within)_zero Sep 22, 2026
@mathlib-bors mathlib-bors Bot closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants