feat(Data/Finsupp/Weight): add degree_strictMono - #43916
qawbecrdtey wants to merge 4 commits into
Conversation
qawbecrdtey
commented
Sep 18, 2026
PR summary 644b02529aImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| (Finset.sum_le_sum_of_subset (support_mono e)).trans (Finset.sum_le_sum fun _ _ ↦ e _) | ||
|
|
||
| lemma degree_strictMono {R : Type*} | ||
| [AddCommMonoid R] [PartialOrder R] [CanonicallyOrderedAdd R] [AddRightStrictMono R] : |
There was a problem hiding this comment.
AddRightStrictMono has the following comment:
You should usually not use this very granular typeclass directly, but rather a typeclass like IsOrderedAddMonoid.
I'm not sure whether this lemma falls under "usually" or not, but you should explain your thinking in the PR summary.
awaiting-author
There was a problem hiding this comment.
L304 uses add_lt_add_of_lt_of_le, which assumes AddRightStrictMono R. Unless there's a workaround, I guess this is reasonable.