Skip to content

[Merged by Bors] - chore(Data/Finset/Max): use to_dual - #43289

Closed
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-Finset.max
Closed

[Merged by Bors] - chore(Data/Finset/Max): use to_dual#43289
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-Finset.max

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

This PR uses to_dual on Finset.max and Finset.max'


Open in Gitpod

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR summary a789708d12

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

- Multiset.exists_min_image
- _root_.Monotone.map_finset_min'
- coe_min'
- exists_min_image
- exists_next_left
- induction_on_min
- induction_on_min_value
- isLUB_iff_isGreatest
- isLUB_mem
- isLeast_min'
- le_min
- le_min'
- le_min'_iff
- le_min_iff
- lt_min'_iff
- map_ofDual_min
- map_toDual_min
- mem_of_min
- min
- min'
- min'_eq_iff
- min'_eq_inf'
- min'_erase_ne_self
- min'_image
- min'_insert
- min'_le
- min'_lt_of_mem_erase_min'
- min'_mem
- min'_pair
- min'_singleton
- min'_subset
- min'_union
- min_empty
- min_eq_bot
- min_eq_inf_withTop
- min_eq_top
- min_erase_ne_self
- min_insert
- min_le
- min_le_of_eq
- min_mem_image_coe
- min_mem_insert_top_image_coe
- min_mono
- min_of_mem
- min_of_nonempty
- min_pair
- min_singleton
- min_union
- notMem_of_coe_lt_min
- notMem_of_lt_min
- ofDual_min'
- toDual_min'

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit a789708).

  • +1 new declarations
  • −0 removed declarations
+Finset.min_eq_inf_coe

No changes to strong technical debt.
No changes to weak technical debt.

Current commit a789708d12
Reference commit df0e53b719

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Sep 1, 2026

@jcommelin jcommelin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Sep 1, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Sep 1, 2026
This PR uses `to_dual` on `Finset.max` and `Finset.max'`
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Sep 1, 2026
@mathlib-bors

mathlib-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(Data/Finset/Max): use to_dual [Merged by Bors] - chore(Data/Finset/Max): use to_dual Sep 1, 2026
@mathlib-bors mathlib-bors Bot closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants