updated BaseHead with path-to-URL mapping only for the BrowserPod blogs#422
Conversation
…gs that also exist on the leaningtech.com repo.
Deploying labs-browserpod-previews with
|
| Latest commit: |
6f309ae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e712c7d3.labs-browserpod-previews.pages.dev |
| Branch Preview URL: | https://browserpod-update-blog-canon.labs-browserpod-previews.pages.dev |
|
I've checked this and this seems ok, but the maintainability is very poor. A better approach would be to do this for any post tagged browserpod. This said, the whole duplicated content is a maintenance nightmare. |
|
@GabrielaReyna I'd like your opinion before merging |
GabrielaReyna
left a comment
There was a problem hiding this comment.
Hey! Found two bugs in the BrowserPod canonicals PR during testing:
.html suffix not stripped — the preview deployment appends .html to pathnames (e.g. /blog/browserpod-deep-dive.html), so the canonical lookup was falling through to the labs fallback instead of pointing at browserpod.io. Fixed by updating the normalisation regex to strip .html as well as trailing slashes.
Wrong map keys for 1.0 and 2.0 posts — the lookup table used /blog/browserpod-1.0 and /blog/browserpod-2.0 as keys, but the actual paths on the site are /blog/browserpod-10 and /blog/browserpod-20 (no dot). Those entries were never matching. Fixed by correcting the keys.
Both fixes are on the branch now.
Ensuring blogs canonical point to the browserpod.io versions (i.e., in leaningtech.com repo).