Add glob and !env features - #3
Open
samuel-deal-tisseo wants to merge 1 commit into
Open
Conversation
Owner
|
Hey, thank you very much having reach me with this, that's very cool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Here a rework of your library with the additional features
!env HOME)!include "**/*.yaml")Technically:
anyhowwiththiserrorfor the library part (because I've read somewhere that's the way to go)Context:
I liked your library but I needed some additional features.
So I forked and I have tuned it my way.
It's my first rust project so even if I tried to make it the best I could, the code should be reviewed.
I'm really sorry this looks more like a rewrite than a feature push.
I had to give it to you back, because it would not exists without your prior work.
Any feedback is welcome if you have time