feat: add TrackingLineParser for source-line-accurate event attribution - #77
Merged
Conversation
LineParser's look-ahead buffering and internal event queue decouple events from the input lines that produced them. TrackingLineParser wraps LineParser and maintains a FIFO queue of pending line numbers, using a pendingEventCount hook on LineParser to compute exact attribution for all edge cases (buffered look-ahead, comment-continuation merges, fatalError double-event path). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
I found an attribution bug for an unparseable Reproduced locally on this commit: The last event comes from input line 2, so it should be attributed to line 2. Could you add a regression test and handle this path? |
LineParser's flushRecordedIssue can resolve a buffered look-ahead line with no event while enqueueing an unrelated overflow event in the same call. TrackingLineParser didn't distinguish that dead-slot case from a plain .ignored line, so it left a stale queue entry and misattributed the next real event to the dead buffered line instead of its actual source line. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexey1312
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
LineParser's look-ahead buffering and internal event queue decouple events from the input lines that produced them. TrackingLineParser wraps LineParser and maintains a FIFO queue of pending line numbers, using a pendingEventCount hook on LineParser to compute exact attribution for all edge cases (buffered look-ahead, comment-continuation merges, fatalError double-event path).