feat: add reasoning_content support for thinking models#119
Open
cloorc wants to merge 4 commits into
Open
Conversation
cloorc
marked this pull request as draft
June 5, 2026 00:17
- Add reasoning_content field to ChatMessage - Emit Reasoning as separate Message::Assistant at SDK level - Merge Reasoning into subsequent Text/ToolCall ChatMessage in conversions - Echo reasoning_content in requests to satisfy thinking models (DeepSeek R1) - Do NOT merge consecutive ToolCall messages — preserve original LLM turn grouping Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Cloorc <wittcnezh@foxmail.com>
cloorc
marked this pull request as ready for review
June 5, 2026 03:57
Providers that support `stream_options.include_usage` (OpenAI, agnes) emit token usage in a trailing chunk whose choices carry no `finish_reason`. The stream consumer stops once a text-completion `Done` is emitted, so that trailing chunk was never read and its usage silently dropped (0/0 tokens). Defer the text-completion `Done` until usage arrives in a trailing chunk, the stream signals `[DONE]`, or the connection closes. Flush without usage on stream end so the assistant message is still recorded when no usage chunk is sent. Signed-off-by: Cloorc <wittcnezh@foxmail.com>
Add `prompt_cache_miss_tokens` field to the OpenAI provider's Usage struct and propagate it through to the SDK's core Usage type, including support in the Add impl for aggregation. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Cloorc <wittcnezh@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of the changes.
Related Issue
Closes #[issue_number]
Type of Change
Checklist