Desktop, Mobile, Cli: Fix note screen is not properly refreshed when updated by the sync, when E2EE is enabled

[mrjo118]

PR #16150 fixed an issue whereby the note viewer / editor on mobile does not get refreshed upon the open note being updated via the sync. However, this caused a regression, as it turns out the existing shared.reloadNote function does not actually work properly with notes which still have E2EE applied (which is the case immediately after a change is synced), and it simply displays a blank note viewer / editor if refreshed immediately after syncing an update to the note, where E2EE is enabled.

This PR addresses the issue by decrypting the note immediately upon reloading the note, and waiting for the decryption to complete before updating the screen. Additionally, the DecryptionWorker has been amended to avoid decrypting and re-saving the note if the latest version of the note has the encryption removed, since decrypting other items in the decryption loop. This is in order to prevent a race condition which could cause content in the editor to be lost, if the decryption worker is running slowly and takes a while to reach the note which was already decrypted. This also aids PR #16023 which also makes use of on demand decryption of E2EE encrypted notes, which will prevent the decryption worker from potentially overwriting an automatically resolved conflict.

Testing

In order to test the DecryptionWorker change, I artifically added delays for both the on demand decryption and before starting the inner loop of the DecryptionWorker after selecting the items for decryption. Using these changes locally, I could produce this race condition which I verified from the log that this occurred and did not cause any issues.

Video demonstrating the issue when a conflict refreshes the note with E2EE enabled, before the change:

Screen_Recording_20260809_234949_Joplin2.mp4

Demonstrating the issue resolved, after the change:

Screen_Recording_20260810_000501_Joplin2.mp4

[coderabbitai]

.