Skip to content

#17: Ability to list existing credentials item contained in keyring#19

Merged
davidferlay merged 1 commit into
mainfrom
17-ability-to-list-existing-credentials-item-contained-in-keyring
Jun 10, 2025
Merged

#17: Ability to list existing credentials item contained in keyring#19
davidferlay merged 1 commit into
mainfrom
17-ability-to-list-existing-credentials-item-contained-in-keyring

Conversation

@iignatevich

Copy link
Copy Markdown
Collaborator

No description provided.

@iignatevich iignatevich linked an issue May 22, 2025 that may be closed by this pull request
@iignatevich
iignatevich marked this pull request as draft May 22, 2025 12:39
Comment thread plugin.go Outdated
@iignatevich
iignatevich force-pushed the 17-ability-to-list-existing-credentials-item-contained-in-keyring branch 2 times, most recently from f85cbc2 to a1adbbf Compare May 26, 2025 09:28
@davidferlay

Copy link
Copy Markdown
Contributor

Tested ok 🆗

will require 1 line code update after global flags will be merged

@davidferlay

davidferlay commented May 26, 2025

Copy link
Copy Markdown
Contributor

Maybe would be great to change numbers with dashes

Enter passphrase to unlock the keyring: 
 INFO  Key-value pairs:
1) sshpass
2) vaultpass
 INFO  URLs:
1) https://projects.skilld.cloud/skilld/pla-work.git
2) https://projects.skilld.cloud/skilld/pla-learn.git
3) https://projects.skilld.cloud/skilld/pla-intelligence.git
4) https://repositories.skilld.cloud
5) https://repositories.skilld.cloud/repository/pla-plasmactl-raw/stable_release
6) https://projects.skilld.cloud/skilld/pla-talk.git
7) https://projects.skilld.cloud/skilld/pla-plasma.git

to

Enter passphrase to unlock the keyring: 
 INFO  Key-value pairs:
- sshpass
- vaultpass
 INFO  URLs:
- https://projects.skilld.cloud/skilld/pla-work.git
- https://projects.skilld.cloud/skilld/pla-learn.git
- https://projects.skilld.cloud/skilld/pla-intelligence.git
- https://repositories.skilld.cloud
- https://repositories.skilld.cloud/repository/pla-plasmactl-raw/stable_release
- https://projects.skilld.cloud/skilld/pla-talk.git
- https://projects.skilld.cloud/skilld/pla-plasma.git

@iignatevich
iignatevich force-pushed the 17-ability-to-list-existing-credentials-item-contained-in-keyring branch from a1adbbf to fbf7a78 Compare May 26, 2025 13:46
@davidferlay

Copy link
Copy Markdown
Contributor

Would be great to print a specific message when no credential item is found (ie no keyring)

@iignatevich
iignatevich force-pushed the 17-ability-to-list-existing-credentials-item-contained-in-keyring branch from fbf7a78 to e692d22 Compare June 5, 2025 13:58
@iignatevich
iignatevich force-pushed the 17-ability-to-list-existing-credentials-item-contained-in-keyring branch from e692d22 to 4e15e1a Compare June 9, 2025 13:58
@davidferlay

Copy link
Copy Markdown
Contributor

Nice addition

➜ plx keyring:list
 INFO  No items found in keyring

@davidferlay
davidferlay marked this pull request as ready for review June 10, 2025 09:31
@davidferlay

Copy link
Copy Markdown
Contributor

Tested OK 👍

@davidferlay
davidferlay merged commit 0c779aa into main Jun 10, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to list existing credentials item contained in keyring

3 participants