Repository navigation
Conversation
Each call starts opencode serve from the working directory, config file, and environment, speaks the OpenCode HTTP API itself, and stops the process when the stream finishes or the caller closes it. Callers no longer pass base_url. A test can pass a fake command instead of a URL. config().stream() is unchanged. Co-authored-by: alexis <alexis@launchdarkly.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c5f4634. Configure here.
async with handler starts the process and waits until it is healthy. The process stops when that context exits, after config().stream() returns, including when the caller times out or closes the stream. A wall-clock budget stays around config().stream(), so boot is not part of it. Co-authored-by: alexis <alexis@launchdarkly.com>
--print-logs and --log-level are not serve options. A binary that rejects them exits before it listens, and the handler already discards the child's output. Co-authored-by: alexis <alexis@launchdarkly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each call starts
opencode serve, speaks the OpenCode HTTP API, and stops the process when the stream finishes or the caller closes it.create_opencode_handlertakes the working directory, the OpenCode config file, and the child environment (cwd,config,env), plus the existing optionalcapture_content,model, andagent.commanddefaults toopencode; a test passes a fake executable there. There is nobase_url, client, or transport.config().stream()is stillchunkthendone.A fake
opencodeproves the handler started the process, sent/event,/session, and/messageto it, and stopped it. Closing the stream aborts the session and stops the process. Removing that ownership fails the test.