Repository navigation
test: Make the Vue and React Native contract test WebSocket extend the shared base - #2141
Merged
Merged
Conversation
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
force-pushed
the
skz/SDK-3426/vue-rn-ws-conform
branch
2 times, most recently
from
October 30, 2026 22:24
13f0e39 to
7247f61
Compare
joker23
force-pushed
the
skz/SDK-3426/vue-rn-ws-conform
branch
2 times, most recently
from
November 2, 2026 14:40
0d093cc to
6739dae
Compare
joker23
force-pushed
the
skz/SDK-3426/vue-rn-ws-conform
branch
from
November 2, 2026 15:10
6739dae to
30ff88a
Compare
joker23
force-pushed
the
skz/SDK-3426/vue-rn-ws-conform
branch
from
November 2, 2026 15:15
30ff88a to
8f673e3
Compare
joker23
marked this pull request as ready for review
November 2, 2026 16:01
kinyoklion
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capabilitiesandonConnectionChangeoptions to the shared base. Defaults keep the browser and React behavior unchanged.disconnect(). React Native already did this. The browser and React entities gain it.Note
Overview
Vue and React Native contract-test harness WebSockets no longer implement their own connect/reconnect and command dispatch loops. They extend the shared
TestHarnessWebSocketbase and only supply SDK-specific client lifecycle hooks (createClient,getCommandHandler,deleteClient) plus a per-SDKCAPABILITIESlist passed into the base constructor.The shared base gains an optional
onConnectionChangecallback (used by React Native) and error logging when client creation or commands fail. Reconnect behavior afterdisconnect()is centralized on the base (guarded by_intentionalClose), matching what React Native already did locally.TestHarnessWebSocketOptionsis exported from the contract-test-utils client entry.Reviewed by Cursor Bugbot for commit 9cc1df0. Bugbot is set up for automated code reviews on this repo. Configure here.