Repository navigation
Conversation
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
marked this pull request as ready for review
October 29, 2026 21:15
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
Overview
Refactors the React contract-test harness so
TestHarnessWebSocketsubclasses the sharedBaseTestHarnessWebSocketfrom@launchdarkly/js-contract-test-utils/client, matching the browser contract-test pattern.The local WebSocket connect/reconnect loop,
getCapabilitiesresponse, and command dispatch forcreateClient,runCommand, anddeleteClientare removed from the React app. Those behaviors now live in the base class; React only wires three hooks—createClient,getCommandHandler, anddeleteClient—to the existing callbacks and command-handler map.Reviewed by Cursor Bugbot for commit e16dae4. Bugbot is set up for automated code reviews on this repo. Configure here.