Repository navigation
docs: Document the overrideAffected flag metadata key in the OpenFeature Node.js provider README - #2111
Draft
kinyoklion wants to merge 1 commit into
Draft
docs: Document the overrideAffected flag metadata key in the OpenFeature Node.js provider README#2111kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
…ure Node.js provider README Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
overrideAffectedkey to the Flag Metadata table in the@launchdarkly/openfeature-node-serverREADME.overrideAffected: truein OpenFeature flag metadata (viatranslateResultinopenfeature-server-common), but the README table still listed only the six keys from before.dataSystem.overrides, so that provider never returns this key.Details
Requirements
Related issues
Describe the solution you've provided
One new row in the Flag Metadata table. The table is re-padded to prettier's table formatting.
Describe alternatives you've considered
Leaving the key out of the docs until the spec covers it. Decided against: the key already ships, and hook authors can see it.
Additional context
The OpenFeature provider spec (
OFP3.3.1) does not listoverrideAffectedyet, andOFP3.3.3 says a provider MUST NOT add keys the spec doesn't define ("New keys are added to this spec first"). Someone needs to decide whether to add the key toOFPor drop it from the provider. This PR only documents what the provider does today.Link to Devin session: https://app.devin.ai/sessions/1fed835aeab841a3bedc9471e008f80c
Open in Devin Desktop: https://app.devin.ai/desktop/session/1fed835aeab841a3bedc9471e008f80c?variant=devin
Requested by: @kinyoklion
SDK-3356