Skip to content

test: enable bootstrap contract tests #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joker23 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: enable bootstrap contract tests #2093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c99b20
test: enable bootstrap contract tests
joker23 Oct 9, 2026
feb1852
ci: treat null bootstrap configuration as abset in contract test serv…
joker23 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,11 @@ export async function newSdkClientEntity(options: CreateInstanceParams) {
initialContext,
sdkConfig,
);
const { status } = await client.start({ timeout: timeout / 1000 });
const bootstrap = options.configuration.clientSide?.bootstrap;
const { status } = await client.start({
timeout: timeout / 1000,
...(bootstrap != null && { bootstrap }),
});
const failed = status !== 'complete';
if (failed && !options.configuration.initCanFail) {
client.close();
Expand Down
1 change: 1 addition & 0 deletions packages/sdk/browser/contract-tests/entity/src/TestHarnessWebSocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export default class TestHarnessWebSocket {
'client-per-context-summaries',
'track-hooks',
'fdv1-fallback',
'bootstrap',
];

break;
Expand Down
1 change: 1 addition & 0 deletions packages/sdk/node-client/contract-tests/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ app.get('/', (req: Request, res: Response) => {
'wrapper',
'fdv1-fallback',
'client-event-source-http-errors',
'bootstrap',
],
});
});
Expand Down
6 changes: 5 additions & 1 deletion packages/sdk/node-client/contract-tests/src/sdkClientEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,11 @@ export async function newSdkClientEntity(options: CreateInstanceParams): Promise
initialContext,
sdkConfig,
);
const startResult = await client.start({ timeout: timeout / 1000 });
const bootstrap = options.configuration.clientSide?.bootstrap;
const startResult = await client.start({
timeout: timeout / 1000,
...(bootstrap != null && { bootstrap }),
});
const failed = startResult.status !== 'complete';
if (failed && !options.configuration.initCanFail) {
await client.close();
Expand Down
7 changes: 6 additions & 1 deletion packages/sdk/react-native/contract-tests/entity/src/ClientEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,8 +364,13 @@ export async function newSdkClientEntity(options: CreateInstanceParams) {

let failed = false;
try {
const bootstrap = options.configuration.clientSide?.bootstrap;
await Promise.race([
client.identify(initialContext, { timeout: timeout / 1000, waitForNetworkResults: true }),
client.identify(initialContext, {
timeout: timeout / 1000,
waitForNetworkResults: true,
...(bootstrap != null && { bootstrap }),
}),
new Promise((_resolve, reject) => {
setTimeout(reject, timeout);
}),
Expand Down
1 change: 1 addition & 0 deletions packages/sdk/react-native/contract-tests/entity/src/TestHarnessWebSocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export default class TestHarnessWebSocket {
'track-hooks',
'fdv1-fallback',
'client-event-source-http-errors',
'bootstrap',
];

break;
Expand Down
6 changes: 5 additions & 1 deletion packages/sdk/react/contract-tests/app/ClientRoot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@ export default function ClientRoot({ children }: { children: React.ReactNode })
sdkConfig,
);

const { status } = await client.start({ timeout: timeout / 1000 });
const bootstrap = params.configuration.clientSide?.bootstrap;
const { status } = await client.start({
timeout: timeout / 1000,
...(bootstrap != null && { bootstrap }),
});

if (status === 'failed' && !params.configuration.initCanFail) {
client.close();
Expand Down
1 change: 1 addition & 0 deletions packages/sdk/react/contract-tests/app/TestHarnessWebSocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export default class TestHarnessWebSocket {
'client-per-context-summaries',
'track-hooks',
'fdv1-fallback',
'bootstrap',
];
break;

Expand Down
2 changes: 2 additions & 0 deletions packages/sdk/vue/contract-tests/src/ClientEntity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,10 @@ export async function newSdkClientEntity(options: CreateInstanceParams) {
// Forward a harness-supplied secure mode hash as the `h` query parameter, only when
// the harness actually configured one.
const secureModeHash = options.configuration.clientSide?.hash;
const bootstrap = options.configuration.clientSide?.bootstrap;
const result = await client.start({
timeout: timeout / 1000,
...(bootstrap != null && { bootstrap }),
...(secureModeHash !== undefined && { identifyOptions: { hash: secureModeHash } }),
});
if (result.status !== 'complete') {
Expand Down
1 change: 1 addition & 0 deletions packages/sdk/vue/contract-tests/src/TestHarnessWebSocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export default class TestHarnessWebSocket {
'secure-mode-hash',
'flag-change-listeners',
'fdv1-fallback',
'bootstrap',
];

break;
Expand Down
1 change: 1 addition & 0 deletions packages/tooling/contract-test-utils/src/types/ConfigParams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ export interface SDKConfigClientSideParams {
useReport?: boolean;
includeEnvironmentAttributes?: boolean;
hash?: string;
bootstrap?: unknown;
}

export interface SDKConfigEvaluationHookData {
Expand Down
Loading