Repository navigation
Conversation
joker23
added this pull request to stack #2035
September 18, 2026 20:32
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
September 18, 2026 20:55
9c38ea8 to
724e94a
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
September 18, 2026 21:36
724e94a to
4fe3c92
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
September 21, 2026 13:44
4fe3c92 to
197417a
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
4 times, most recently
from
September 22, 2026 19:53
b1572a2 to
684ed50
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
September 22, 2026 20:36
684ed50 to
d5c5d4d
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
September 22, 2026 21:44
d5c5d4d to
039c061
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
September 23, 2026 16:32
039c061 to
cd08556
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
2 times, most recently
from
September 24, 2026 14:07
e73c276 to
8701dc9
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
September 24, 2026 14:23
8701dc9 to
e4e333c
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
September 24, 2026 15:20
e4e333c to
7164a19
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
3 times, most recently
from
September 29, 2026 20:32
b54f923 to
6760a28
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
2 times, most recently
from
September 30, 2026 22:21
8c29bda to
1f93481
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
October 1, 2026 17:01
1f93481 to
b17e046
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
2 times, most recently
from
October 5, 2026 18:24
3f05376 to
fd9e7c8
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
October 6, 2026 13:15
fd9e7c8 to
42838fd
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
from
October 6, 2026 13:43
42838fd to
596108e
Compare
joker23
force-pushed
the
skz/sdk-3151/common-eventsource-node-consumers
branch
2 times, most recently
from
October 7, 2026 15:55
02bfa05 to
4a7be4e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
fetch()-basedEventSourceto the browser SDK behind its own@launchdarkly/js-client-sdk/fetch-eventsourceentry point, so neither the implementation nor its dependency reaches the default bundle. The native browserEventSourceremains the default. Includes theeventSourcefactory option plumbing, an example app, and bundle-size coverage.On top of that, the browser contract test entity declares the
client-use-postcapability and injects the fetch-basedEventSourcewhenever the harness configuresusePostoruseReport, so the FDv2 POST variants and the FDv1 REPORT streaming variants now run. Stale suppressions removed accordingly (6 REPORT lines fromsuppressions.txt, 22 dead lines fromsuppressions_datamode_changes.txt); verified locally with no-suppression harness runs (FDv1: 823 ran, FDv2: 795 ran incl. 20 POST variants, all critical tests passed).Replaces #2034 and #2048, which GitHub auto-marked merged during a stack reorder; their bot-review history lives there.