Skip to content

feat: Add an opt-in fetch-based EventSource entry to the browser SDK - #2033

Draft
joker23 wants to merge 7 commits into
skz/sdk-3150/common-eventsource-sdk-client-optionsfrom
skz/sdk-3151/common-eventsource-node-consumers
Draft

joker23 wants to merge 7 commits into
skz/sdk-3150/common-eventsource-sdk-client-optionsfrom
skz/sdk-3151/common-eventsource-node-consumers

Conversation

@joker23

@joker23 joker23 commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds an opt-in fetch()-based EventSource to the browser SDK behind its own @launchdarkly/js-client-sdk/fetch-eventsource entry point, so neither the implementation nor its dependency reaches the default bundle. The native browser EventSource remains the default. Includes the eventSource factory option plumbing, an example app, and bundle-size coverage.

On top of that, the browser contract test entity declares the client-use-post capability and injects the fetch-based EventSource whenever the harness configures usePost or useReport, so the FDv2 POST variants and the FDv1 REPORT streaming variants now run. Stale suppressions removed accordingly (6 REPORT lines from suppressions.txt, 22 dead lines from suppressions_datamode_changes.txt); verified locally with no-suppression harness runs (FDv1: 823 ran, FDv2: 795 ran incl. 20 POST variants, all critical tests passed).

Replaces #2034 and #2048, which GitHub auto-marked merged during a stack reorder; their bot-review history lives there.

@joker23
joker23 added this pull request to stack #2035 September 18, 2026 20:32
@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 29603 bytes
Compressed size limit: 30000
Uncompressed size: 142116 bytes

@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25686 bytes
Compressed size limit: 44000
Uncompressed size: 166718 bytes

@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 32947 bytes
Compressed size limit: 34000
Uncompressed size: 118122 bytes

@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from 9c38ea8 to 724e94a Compare September 18, 2026 20:55
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from 724e94a to 4fe3c92 Compare September 18, 2026 21:36
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from 4fe3c92 to 197417a Compare September 21, 2026 13:44
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch 4 times, most recently from b1572a2 to 684ed50 Compare September 22, 2026 19:53
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from 684ed50 to d5c5d4d Compare September 22, 2026 20:36
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from d5c5d4d to 039c061 Compare September 22, 2026 21:44
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from 039c061 to cd08556 Compare September 23, 2026 16:32
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch 2 times, most recently from e73c276 to 8701dc9 Compare September 24, 2026 14:07
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from 8701dc9 to e4e333c Compare September 24, 2026 14:23
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from e4e333c to 7164a19 Compare September 24, 2026 15:20
@joker23
joker23 deleted the skz/sdk-3151/common-eventsource-node-consumers branch September 29, 2026 19:09
@joker23
joker23 restored the skz/sdk-3151/common-eventsource-node-consumers branch September 29, 2026 19:11
@joker23 joker23 reopened this Sep 29, 2026
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch 3 times, most recently from b54f923 to 6760a28 Compare September 29, 2026 20:32
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch 2 times, most recently from 8c29bda to 1f93481 Compare September 30, 2026 22:21
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from 1f93481 to b17e046 Compare October 1, 2026 17:01
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch 2 times, most recently from 3f05376 to fd9e7c8 Compare October 5, 2026 18:24
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from fd9e7c8 to 42838fd Compare October 6, 2026 13:15
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch from 42838fd to 596108e Compare October 6, 2026 13:43
@joker23
joker23 force-pushed the skz/sdk-3151/common-eventsource-node-consumers branch 2 times, most recently from 02bfa05 to 4a7be4e Compare October 7, 2026 15:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant