Repository navigation
Conversation
joker23
added this pull request to stack #2035
September 18, 2026 20:32
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
September 18, 2026 20:54
a0d5217 to
06c2b30
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
September 18, 2026 21:35
06c2b30 to
6f792c9
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
September 21, 2026 13:44
6f792c9 to
dd6776f
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
3 times, most recently
from
September 22, 2026 19:43
b9636ed to
d0601a6
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
September 22, 2026 19:53
d0601a6 to
55953d7
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
2 times, most recently
from
September 22, 2026 21:44
670ac07 to
571e2e3
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
September 23, 2026 16:32
571e2e3 to
8ee6c98
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
September 23, 2026 19:26
8ee6c98 to
73835c5
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
September 24, 2026 14:07
73835c5 to
a1ec7a0
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
2 times, most recently
from
September 24, 2026 15:20
0e9a389 to
cef8863
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
October 1, 2026 18:05
fda03ff to
bf66a54
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
October 5, 2026 18:24
bf66a54 to
ce76718
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
3 times, most recently
from
October 7, 2026 15:32
8a349f0 to
8ab663e
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
October 7, 2026 15:55
8ab663e to
0d2bbd1
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
3 times, most recently
from
October 7, 2026 20:52
401bed7 to
379fff1
Compare
Base automatically changed from
skz/sdk-3149/common-eventsource-contract-tests
to
main
October 7, 2026 21:48
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
October 7, 2026 21:48
379fff1 to
2cb6473
Compare
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
2 times, most recently
from
October 8, 2026 16:13
379fff1 to
a757d2c
Compare
joker23
added a commit
that referenced
this pull request
Oct 8, 2026
This PR will do a pre-release of the new `@launchdarkly/eventsource` module. > NOTE: this PR could be merged in parallel to #2032 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > **Wires `@launchdarkly/eventsource` (`packages/shared/eventsource`) into automated release and docs publishing** so it can ship as a **0.0.1 prerelease** via release-please. > > Release-please gains a manifest entry, package config with `prerelease: true` and `bump-minor-pre-major`, a `release-eventsource` job/output, and the workspace is added to manual doc publish and release workflow choices. A bump to `@launchdarkly/js-sdk-common` in `packages/shared/common` is tied to eventsource’s `package.json` devDependency. > > The eventsource **README** is expanded with install/quick-start, API surface notes, and runnable examples for events, retry/backoff, `errorFilter`, and custom request options. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 59cd76a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
joker23
marked this pull request as draft
October 8, 2026 19:30
Contributor
Author
|
moved this back to draft so I can sneak in another layer below this one. |
joker23
force-pushed
the
skz/sdk-3150/common-eventsource-sdk-client-options
branch
from
October 8, 2026 19:34
a757d2c to
76025e6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two pieces to the client-side SDK common in support of customizable streaming transports:
LDEventSourceFactory: a public contract for supplying a customEventSourceimplementation (createEventSource(url, initDict)plus acapabilitiesdeclaration --customMethod,headers,readTimeout). The SDK consults the declared capabilities before using a transport feature; a factory that declares nothing is treated as supporting nothing.usePostoption (early access, FDv2dataSystemonly): when enabled, streaming and polling flag requests use POST with the evaluation context in the request body instead of GET with the context in the URL path, keeping the context out of URL-based request logs. Streaming POST requires anEventSourcewhose factory declarescustomMethod; because there is no fallback on that path, the client throws at construction time ifusePostis set without a compatibleEventSource.useReporthas no effect under FDv2 (usePostis its equivalent there) -- it is ignored with a warning rather than silently changing behavior.Plumbing: the FDv2 streaming base accepts a method and body, and the source factory provider selects the POST paths and passes the context body through to both the stream and its polling requestor. Covered by new construction-guard, provider, and streaming-base tests.
🤖 Generated with Claude Code
Note
Overview
Adds
LDEventSourceFactoryas a public contract for custom streaming transports, including optionalcapabilities(notablycustomMethod) that the SDK consults before using non-default HTTP methods on streams.Introduces the early-access
usePostoption for FDv2 whendataSystemis enabled: polling and streaming can send the evaluation context in a POST body instead of a GET URL. Streaming POST is used only when the platform EventSource reportscustomMethod; otherwise the client logs a warning and streaming stays on GET while polling still uses POST.useReportis documented and enforced as ineffective underdataSystem(warning + forced off; useusePostinstead).Wiring runs through configuration validation,
SourceFactoryProvider(path selection and method/body onStreamingFDv2Base), and client construction checks inLDClientImpl. Tests cover provider behavior, POST stream init, and config warnings.Reviewed by Cursor Bugbot for commit a757d2c. Bugbot is set up for automated code reviews on this repo. Configure here.