Skip to content

fix: Treat a repeated override file path in a different case as a repeat on Windows - #494

Open
kinyoklion wants to merge 1 commit into
v7from
rlamb/overrides-go-repeated-paths-case
Open

kinyoklion wants to merge 1 commit into
v7from
rlamb/overrides-go-repeated-paths-case

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary

The file-based override source drops a path that is listed more than once (#477, released in 7.21.0), so that the file's entries do not collide with themselves. The comparison was exact. On Windows, where file names ignore case, a path repeated in a different case (C:\overrides\a.json and c:\Overrides\A.JSON) survived, and every key in that file then failed as its own duplicate under the default fail handling, so the reload failed and no overrides from it applied.

On Windows the comparison now ignores case. Elsewhere it stays exact, because a case-sensitive file system can hold both names as different files. The deduplication moves into uniqueFilePaths, so both behaviors are tested on every platform.

This is the gap that Bugbot found in the .NET port (launchdarkly/dotnet-core#367). The Node change is launchdarkly/js-core#2134.

Tests

  • TestUniqueFilePathsIgnoresCaseOnlyWhenFileNamesIgnoreCase checks both modes directly. It fails with case folding disabled.
  • TestFileSourceTreatsAPathRepeatedInDifferentCaseAsARepeatOnlyOnWindows builds a source from two paths that differ in case: one path on Windows, both elsewhere.

go test -race ./... passes and make lint reports no issues.

Opened from termag

SDK-3419


Note

Overview
Fixes file-based override sources on Windows where listing the same path twice with different casing (e.g. C:\overrides\a.json and c:\Overrides\A.JSON) was not treated as a duplicate. That let the file load twice and triggered duplicate-key failures under default handling, so overrides could fail to apply.

Path deduplication is moved into uniqueFilePaths, which compares paths case-insensitively when ignoreCase is true (enabled on Windows via runtime.GOOS). On case-sensitive systems, comparison stays exact so two paths that differ only by case can still refer to different files.

Tests cover both modes of uniqueFilePaths and assert build-time behavior on Windows vs other platforms.

Reviewed by Cursor Bugbot for commit ebaff4f. Bugbot is set up for automated code reviews on this repo. Configure here.

…eat on Windows

The file-based override source drops a path listed more than once, so
that the file's entries are not duplicates of themselves. The comparison
was exact, so on Windows, where file names ignore case, a path repeated
in a different case survived and every key of that file failed as its
own duplicate under the default fail handling. On Windows the comparison
now ignores case; elsewhere it stays exact.
@kinyoklion

Copy link
Copy Markdown
Member Author

bugbot review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit ebaff4f. Configure here.

@kinyoklion
kinyoklion marked this pull request as ready for review October 30, 2026 23:55
@kinyoklion
kinyoklion requested a review from a team as a code owner October 30, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant