Support encoding comments by exposing the type#48
Open
dprotaso wants to merge 3 commits into
Open
Conversation
dprotaso
commented
May 14, 2025
keelerm84
reviewed
May 19, 2025
keelerm84
left a comment
keelerm84
left a comment
Member
There was a problem hiding this comment.
I'm not sure I understand the need for this change.
Prior to this it was not possible to publish comments using the encoder
The encoder doesn't publish comments. It encodes them.
The server can publish messages though. And you can publish a comment with it using the PublishComment method.
keelerm84
added
the
waiting for feedback
Author
I'm using your encoder but not your server.
Sorry that was a typo and should say 'encode comments' - updated |
Author
|
Hey any updates? |
Author
|
@keelerm84 any update? |
Prior to this it was not possible to publish comments using the encoder
dprotaso
force-pushed
the
support-encoding-comments
branch
from
59012e0 to
b5b7b03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this it was not possible to encode comments using the
encoder