feat: Add Big Segments support to the server contract-test service#554
Draft
beekld wants to merge 1 commit into
Draft
feat: Add Big Segments support to the server contract-test service#554beekld wants to merge 1 commit into
beekld wants to merge 1 commit into
Conversation
53139f4 to
5836643
Compare
30a59b0 to
2ac1d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Big Segments support to the server contract-test service
Lets the shared contract-test harness run its Big Segments suite (evaluation,
membership caching, status polling, error handling) against the C++ server SDK.
Builds on #552.
What's in
ContractTestBigSegmentStore: anIBigSegmentStorethat delegatesgetMembership/getMetadatato the harness over HTTP (synchronousrequest/response, mirroring
ContractTestHook's callback wiring).bigSegmentsconfig block in the contract-tests data model ->ConfigBuilder::BigSegments(...)in the entity manager.getBigSegmentStoreStatuscommand ->Client::BigSegmentStoreStatus().big-segmentsadded to the advertised capabilities.No SDK changes here --
bigSegmentsStatusalready serializes into the evaluationreason, so it flows through the existing evaluate path.
Design notes
io_contextrather than theSDK executor, so a synchronous callback can't deadlock the SDK's single io
thread during a metadata poll. A non-200 from the harness maps to a store
error;
lastUpToDateof 0 maps to "never synchronized".implementations themselves are tested against real Redis/DynamoDB at the
source-library level separately.
Testing
13 skipped, 0 failed).
server-testsbuilds and advertisesbig-segments.