Repository navigation
feat: hand users the Factory GitHub connect link - #189
Merged
Merged
Conversation
When the GitHub App is not installed or this member has not authorized, the skill gives them githubConnectUrl and retries after they finish. Co-authored-by: Cursor <cursoragent@cursor.com>
Skill eval results
Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline. |
sarahlessner
marked this pull request as ready for review
October 5, 2026 18:22
Contributor
|
Review: Bugbot's one finding was valid and is fixed in c750f11. The PR-diagnosis path now stops only on Other notes:
|
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c750f11. Configure here.
dariushar
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list-factory-github-reposreturnsgithubConnectUrl, the Factory settings skill gives the user that link and waits, then retries.flow=installis Install GitHub App.flow=authorizeis Authorize GitHub. The skill does not complete GitHub OAuth itself.Test plan
githubConnectUrlinstead of stopping at "install it in the UI"githubConnectUrl) still confirms before any settings writeMade with Cursor