Skip to content

feat: hand users the Factory GitHub connect link - #189

Merged
sarahlessner merged 2 commits into
mainfrom
sarah/EMSR-1750/factory-github-connect-skill
Oct 6, 2026
Merged

sarahlessner merged 2 commits into
mainfrom
sarah/EMSR-1750/factory-github-connect-skill

Conversation

@sarahlessner

Copy link
Copy Markdown
Contributor

Summary

  • When list-factory-github-repos returns githubConnectUrl, the Factory settings skill gives the user that link and waits, then retries.
  • flow=install is Install GitHub App. flow=authorize is Authorize GitHub. The skill does not complete GitHub OAuth itself.

Test plan

  • Ask an agent to map a repo on an account where the GitHub App is not installed or this member has not authorized, and confirm it shows githubConnectUrl instead of stopping at "install it in the UI"
  • Confirm a ready install (no githubConnectUrl) still confirms before any settings write

Made with Cursor

When the GitHub App is not installed or this member has not authorized, the skill gives them githubConnectUrl and retries after they finish.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Skill eval results

Skill Before After Δ
agentcontrol/configs-create 100/100 (4/4) 75/100 (3/4) -25
agentcontrol/configs-update 80/100 (4/5) 80/100 (4/5) no change
agentcontrol/configs-variations 80/100 (4/5) 80/100 (4/5) no change
agentcontrol/tools 75/100 (3/4) 75/100 (3/4) no change
feature-flags/flag-and-release-change - 100/100 (4/4) new
feature-flags/flag-release - 100/100 (5/5) new
feature-flags/launchdarkly-flag-command - 100/100 (3/3) new
feature-flags/launchdarkly-flag-create 100/100 (3/3) 100/100 (4/4) no change
feature-flags/launchdarkly-flag-drift - 100/100 (4/4) new
feature-flags/should-flag-change - 100/100 (17/17) new
onboarding - 75/100 (3/4) new

Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline.

@sarahlessner
sarahlessner marked this pull request as ready for review October 5, 2026 18:22

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread skills/factory/launchdarkly-factory-settings/SKILL.md Outdated
@devin-ai-integration

Copy link
Copy Markdown
Contributor

Review: Bugbot's one finding was valid and is fixed in c750f11. The PR-diagnosis path now stops only on flow=install. flow=authorize is treated as a lookup blocker, not the root cause. validate_skills.py and generate_catalog.py --check pass.

Other notes:

  • Ship after gram-functions#317 is deployed. This removes the old "App not installed → install in the UI" instruction. Against the current server, which has no githubConnectUrl, the agent gets no guidance for installed: false.
  • Step 2 says "if the error … includes githubConnectUrl". Today #317 puts the URL only in the error text, not in a field. I suggested a structured field on #317. The current wording still works either way.
  • Earlier CI failure: the onboarding eval is flaky and unrelated to this change. It passed on re-run. The root cause is a stale eval-scores.json, so all 11 suites re-run on every PR.

Written by Devin

@sarahlessner

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit c750f11. Configure here.

@sarahlessner
sarahlessner requested a review from dariushar October 6, 2026 18:39
@sarahlessner
sarahlessner merged commit 2fc544d into main Oct 6, 2026
18 checks passed
@sarahlessner
sarahlessner deleted the sarah/EMSR-1750/factory-github-connect-skill branch October 6, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants