Add subtitle metrics library (CPS/WPM, overlaps, gaps) with tests - #57
Open
fasuizu-br wants to merge 3 commits into
Open
Add subtitle metrics library (CPS/WPM, overlaps, gaps) with tests#57fasuizu-br wants to merge 3 commits into
fasuizu-br wants to merge 3 commits into
Conversation
Owner
|
Confirmed defects:
Also confirmed:
Can you fix these issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #34 — starting small, as you asked.
This PR adds only the metrics logic and its tests. No UI, no new dependencies, nothing else touched:
lib/subtitle-metrics.ts— pure functions: per-cue CPS/WPM, duration, overlap and gap detection, plus a track-level summary. Thresholds are parameters with documented defaults.tests/subtitle-metrics.test.ts— 9 tests covering known-value CPS/WPM, short duration, overlap, gap above/below threshold, and degenerate input (empty list, end ≤ start, empty text, VTT styling/newlines).Reuses the project's existing time parsing and follows the conventions in
lib/andtests/. Full suite passes locally (npm test).Wiring this into the UI can come later in a separate, equally small PR — whatever shape you prefer for the minimal surface.