CI-check flow, repo-creation safety, and dev-start/dev-complete refactors - #3
Open
vkryzhanovskyi-1544 wants to merge 9 commits into
Open
CI-check flow, repo-creation safety, and dev-start/dev-complete refactors#3vkryzhanovskyi-1544 wants to merge 9 commits into
vkryzhanovskyi-1544 wants to merge 9 commits into
Conversation
Add /dev-check: watches a PR's checks, auto-fixes small mechanical failures, escalates the rest. The full procedure lives in dev-check/references/ci-flow.md so dev-complete reuses it (Step 7 runs it inline after opening a PR). Widen dev-complete allowed-tools so it can apply fixes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add references/pr-description.md: base the PR body on the actual diff and always give an explicit LWC vs non-LWC breakdown (call out Apex/metadata prominently, or state 'LWC only' only after verifying). Point Step 5 at it to stop mislabelling Apex changes as LWC-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Skip setup only when this skill did the fresh setup this session for the same feature; an existing checkout on disk is never a reason to build in place. The 'new feature vs more work on the current one' boundary is the user's call — offer a fresh clone and wait for confirmation, don't auto-restart. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Move the deploy command, the conflict-resolution decision tree, and the success card out of Step 8 into references/deploy.md (loaded on demand); Step 8 item 4 now points to it. Build-location guidance stays in item 3. Keeps SKILL.md lean and separates build from deploy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ermissions Add a hard 'never create a repository' rule to Step 3 (this skill only clones existing repos). In setup-permissions.js: narrow gh repo to list/view/clone, drop the blanket gh api, and hard-deny repo-mutating commands (gh repo create/delete/fork/rename/archive/edit, gh api POST, git init) — deny overrides allow, so it also protects users who still carry a broad rule. Also pre-approve read-only CI commands (gh pr/run), git diff, and the outward push / gh pr create / gh pr edit so the build-and-ship flow runs prompt-free. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tests/check_integrity.py (references resolve, frontmatter valid, JS compiles) and tests/test_permissions.js (safe allowlist merge + repo-creation deny guards). Offline, no side effects, non-zero exit on failure. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an automated CI-check flow for pull requests, hardens the plugin against
ever creating a repository, and refactors the dev-start / dev-complete guidance
for clarity and DRY. Docs + JS only — no Salesforce metadata, no org needed.
What's included (by area)
/dev-checkskill + sharedreferences/ci-flow.md(single source of truth): watch a PR's checks, auto-fix small mechanical
failures (lint + self-inflicted build/deploy, incl. the single-sandbox
cross-branch case), escalate the rest into a note on the PR.
dev-completeStep 7 runs the same flow inline after opening a PR.
references/pr-description.md: PR bodies are now adeveloper-facing analysis grounded in the actual diff, with a mandatory
LWC-vs-non-LWC breakdown (fixes Apex changes being mislabelled "LWC only").
continued-feature boundary is the user's call, not automatic); deploy guidance
extracted into
references/deploy.mdto keep SKILL.md lean.tests/check_integrity.py(references resolve, frontmatter valid,JS compiles) and
tests/test_permissions.js(safe allowlist merge + denyguards). Offline, non-zero exit on failure.
Notable behavior changes — reviewer, look here
populated main, and opened a PR to it. Now
gh repo create/delete/…,gh api … POST, andgit initare hard-denied;gh repois narrowed tolist/view/clone; the blanketgh apiis dropped; and Step 3 carries anexplicit "never create a repository" rule. Deny overrides allow, so users who
still carry a broad
gh repo *from an earlier version are protected too.git push,gh pr create,gh pr edit, the read-only CIcommands (
gh pr/run), andgit diffare now pre-approved so the build-and-ship flow runs prompt-free; the ASK list is emptied.
dev-checkwill commit and push small CI fixes on its own(bounded: ≤2 rounds, no force-push, feature branch only).