Require absolute path from bare-path global linkMapping early return - #25
Merged
Conversation
The early return for bare-path global linkMappings now requires the mapped result to start with "/" (absolute path). This prevents generic global mappings like .md-stripping from hijacking multi-segment relative links (e.g., "types/subscription.md") that should resolve via normalizePath() + sourceToTargetMap. Bumps version to 0.14.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/(absolute path).md-stripping from hijacking multi-segment relative links (e.g.,types/subscription.md) that should resolve vianormalizePath()+sourceToTargetMap.md-stripping global mappingsTest plan
types/subscription.md#anchorresolves via sourceToTargetMap to absolute URL./,../, and sibling reference tests still passtsc --noEmitclean