Fix regression: scope bare-path global linkMappings guard - #23
Merged
Conversation
…aths only The v0.14.2 fix applied global linkMappings to raw paths for all links, but generic global mappings like .md-stripping would over-match relative links (./foo.md, ../bar.md), causing early return and bypassing sourceToTargetMap resolution. Now the pre-normalization pass only runs for bare paths (no ./, ../, /, or protocol prefix). Adds regression tests for ./ and ../ links with .md-stripping global mappings to prevent this class of bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.md-stripping fromgenerateStarlightLinkMappings()) over-matched relative links (./foo.md,../bar.md), bypassingsourceToTargetMapresolutionisBareBarePathguard so pre-normalization global mapping pass only runs for bare paths (no./,../,/, or protocol prefix)./and../links with.md-stripping global mappingsTest plan
./subscriber.mdwith.md-stripping global mappings resolves via sourceToTargetMap../overview.mdwith global mappings resolves via normalization + sourceToTargetMaptsc --noEmitclean