Export LoaderContext type from public API - #17
Merged
Conversation
LoaderContext was marked @internal but is needed by downstream consumers for the multi-loader pattern (context as LoaderContext). Promote it to the public API and restore the cast in the Quick Start README example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoaderContexttype fromindex.ts— downstream consumers (devportal) need it for the multi-loadercontext as LoaderContextcast pattern@internalJSDoc tag fromLoaderContextinterface since it's now public APILoaderContextimport and cast in the Quick Start README exampleTest plan
tsc --noEmitpasses